Project

General

Profile

Actions
Copy link

Anomalie #834

closed

PHP7: installer fix. fatal error on unset($this)

Added by Régis over 6 years ago. Updated over 6 years ago.

Status:
Fermé
Priority:
Normal
Assignee:
Simon
Category:
admin
Target version:
2.1
Start date:
04/06/2018
Due date:
% Done:

100%

Estimated time:
0.25 h
Resolution:

Description

On version 2.0 `www/install/installer/Installer.php` contains this invalid instructions (fatal error on php7):

     # Clear
     unset($this);

The simpliest way of fixing this is to remove this memory cleanup instructions.

Actions
Copy link
 #1

Updated by Simon over 6 years ago

  • Assignee set to Simon
  • Target version set to 2.1
Actions
Copy link
 #2

Updated by Simon over 6 years ago

  • Estimated time set to 0.25 h
Actions
Copy link
 #3

Updated by Simon over 6 years ago

See :


It's not allowed to re-assign $this, so why it should be allowed to unset() it. The following code worked in PHP 7, but will emit compilation error in PHP 7.1

unset($this); // Fatal error: Cannot unset $this
Actions
Copy link
 #4

Updated by Simon over 6 years ago

  • Status changed from Nouveau to Fermé
  • % Done changed from 0 to 100

Applied in changeset linea21|r3337.

Actions
Copy link

Also available in: Atom PDF